Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dedicated instance resource of APIG service #1221

Merged
merged 4 commits into from
Jun 29, 2021
Merged

New dedicated instance resource of APIG service #1221

merged 4 commits into from
Jun 29, 2021

Conversation

Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Jun 19, 2021 •
edited
Loading

What this PR does / why we need it:

  • For the APIG dedicated service, we need to support resource of instances, applications, APIs, environments, etc.
  • As a basic container, instance can manage the following resources:
    • API lifecycle.
    • Environment variables.
    • Request throttling.
    • Monitoring and alarm.
    • Access control.
    • VPC channels.
    • Signature keys.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
reference: #1198

Special notes for your reviewer:

Release note:

1. New dedicated instance release, the following edition are supporte:
  - BASIC, PROFESSIONAL, ENTERPRISE, PLATINUM.
2. Add three acc test for instance:
  - basic configuration and update(name, description, security group and maintenance time).
  - egress binding, unbinding and updation.
  - ingress binding, unbinding and updation.
3. Document supported.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

Basic test

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccApigInstanceV2_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccApigInstanceV2_basic -timeout 360m -parallel 4
=== RUN   TestAccApigInstanceV2_basic
=== PAUSE TestAccApigInstanceV2_basic
=== CONT  TestAccApigInstanceV2_basic
--- PASS: TestAccApigInstanceV2_basic (456.28s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       456.334s

Egress test

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccApigInstanceV2_egress'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccApigInstanceV2_egress -timeout 360m -parallel 4
=== RUN   TestAccApigInstanceV2_egress
=== PAUSE TestAccApigInstanceV2_egress
=== CONT  TestAccApigInstanceV2_egress
--- PASS: TestAccApigInstanceV2_egress (560.10s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       560.145s

Ingress test

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccApigInstanceV2_ingress'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccApigInstanceV2_ingress -timeout 360m -parallel 4
=== RUN   TestAccApigInstanceV2_ingress
=== PAUSE TestAccApigInstanceV2_ingress
=== CONT  TestAccApigInstanceV2_ingress
--- PASS: TestAccApigInstanceV2_ingress (567.09s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       567.177s

@Lance52259 Lance52259 mentioned this pull request Jun 25, 2021
Merged
3 tasks
ShiChangkuo
ShiChangkuo reviewed Jun 29, 2021
View reviewed changes
docs/resources/apig_instance.md Outdated Show resolved Hide resolved
docs/resources/apig_instance.md Outdated Show resolved Hide resolved
huaweicloud/resource_huaweicloud_apig_instance.go Outdated Show resolved Hide resolved
@ShiChangkuo ShiChangkuo merged commit 5c22a53 into huaweicloud:master Jun 29, 2021
@Lance52259 Lance52259 deleted the br_apig_instance_active branch July 15, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiChangkuo ShiChangkuo ShiChangkuo left review comments

@Jason-Zhang9309 Jason-Zhang9309 Awaiting requested review from Jason-Zhang9309

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lance52259 @ShiChangkuo